-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25382] Android: Fix Wrong thread error in DrawerLayout when not running on main thread #9516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
Generated by 🚫 dangerJS |
@Kroll.constant public static final int LOCK_MODE_UNLOCKED = DrawerLayout.LOCK_MODE_UNLOCKED; | ||
@Kroll.constant public static final int LOCK_MODE_UNDEFINED = DrawerLayout.LOCK_MODE_UNDEFINED; | ||
|
||
private static final int MSG_FIRST_ID = KrollProxy.MSG_LAST_ID + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a potential future bug here. The MSG_FIRST_ID
constant should be using TiViewProxy.MSG_LAST_ID
and not KrollProxy.MSG_LAST_ID
in order to avoid ID collision.
private static final int MSG_FIRST_ID = TiViewProxy.MSG_LAST_ID + 1;
@jquick-axway Updated PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
FR Passed. With Studio Ver: 4.10.0.201709271713 |
@sgtcoolguy , Please merge as this is a community PR. |
I'm still seeing a similar error in 7.0.2. It doesn't happen often, but when it does I think it's failing when calling setDisplayHomeAsUp. Here's the call stack: [WARN] W/System.err: android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views. Any ideas? |
The bug still occurs with 7.1 and is very blocking for the users when it happens. |
Any news about it ? |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25382
Optional Description:
It makes sure that action on the menu are run on the UI thread.