Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25546] Simple Code Crash on Android after installing Titanium SDK 7.0.0 Beta #9632

Merged
merged 6 commits into from
Nov 28, 2017
Merged

[TIMOB-25546] Simple Code Crash on Android after installing Titanium SDK 7.0.0 Beta #9632

merged 6 commits into from
Nov 28, 2017

Commits on Nov 28, 2017

  1. Add unit tests.

    @ypbnv @sgtcoolguy
    ypbnv authored and sgtcoolguy committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    6fabac3 View commit details
    Browse the repository at this point in the history

  2. Remove our titanium::Utf8Value and titanium::TwoByteValue and replace… 

    … with v8::String::Utf8Value and v8::String::Value
    @sgtcoolguy
    sgtcoolguy committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    38834c4 View commit details
    Browse the repository at this point in the history

  3. Move unit tests to addon

    @sgtcoolguy
    sgtcoolguy committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    ea2fe1a View commit details
    Browse the repository at this point in the history

  4. Bring back titanium::Utf8Value to provide backwards compat with nativ… 

    …e modules already rebuilt against 7.0. Add note that it's deprecated and to remove it in 8.0. Update native module template to no longer refer to that type.
    @sgtcoolguy
    sgtcoolguy committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    94739da View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into TIMOB-25546

    Lokesh Choudhary committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    0e999a0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into TIMOB-25546

    @sgtcoolguy
    sgtcoolguy committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    615c82a View commit details
    Browse the repository at this point in the history