Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25637] : Window toolbar animates when opening window #9698

Merged
merged 5 commits into from
Jan 12, 2018
Merged

[TIMOB-25637] : Window toolbar animates when opening window #9698

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec7d75e
[TIMOB-25637] : Window toolbar animates when opening window
vijaysingh-axway Jan 3, 2018
70b774b
Merge branch 'master' into TIMOB-25637
vijaysingh-axway Jan 3, 2018
3e21611
[TIMOB-25637] : Updated extendSafeArea unit test as per 7.0.1 change
vijaysingh-axway Jan 8, 2018
feb9e28
Merge branch 'master' into TIMOB-25637
hansemannn Jan 9, 2018
145e206
Merge branch 'master' into TIMOB-25637
mukherjee2 Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/Classes/TiUIWindowProxy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,6 @@ - (void)setupWindowDecorations
return;
}

[[controller navigationController] setToolbarHidden:!hasToolbar animated:YES];
//Need to clear title for titleAttributes to apply correctly on iOS6.
[[controller navigationItem] setTitle:nil];
SETPROP(@"titleAttributes", setTitleAttributes);
Expand All @@ -956,6 +955,7 @@ - (void)setupWindowDecorations
SETPROP(@"translucent", setTranslucent);
SETPROP(@"tabBarHidden", setTabBarHidden);
SETPROPOBJ(@"toolbar", setToolbar);
[[controller navigationController] setToolbarHidden:!hasToolbar animated:YES];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously? Wow. Can we still ensure this doesn't cause side-effects for other use-cases like changing title-attributes etc?

[self updateBarImage];
[self updateNavButtons];
[self refreshBackButton];
Expand Down