[TIMOB-25747] iOS: Fix error dialog from not showing up when using main thread #9797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysingh-axway
suggested changes
Feb 5, 2018
iphone/Classes/TiErrorController.m
Outdated
| @@ -16,7 +16,19 @@ @implementation TiErrorController | |||
| - (id)initWithError:(NSString *)error_ | |||
| { | |||
| if (self = [super init]) { | |||
| error = [error_ retain]; | |||
| error = [NSString stringWithFormat:@"⚠️ %@", [error_ retain]]; | |||
There was a problem hiding this comment.
error is autoreleased object and in dealloc it is released again, it will cause crash. No need of retaining error_ object. It should be -
error = [[NSString alloc] initWithFormat:@"
There was a problem hiding this comment.
Copy paste error :-) Fixed!
iphone/Classes/TiErrorController.m
Outdated
| error = [NSString stringWithFormat:@"⚠️ %@", [error_ retain]]; | ||
|
|
||
| if (reason_ != nil) { | ||
| reason = [NSString stringWithFormat:@"%@", [reason_ retain]]; |
Generated by 🚫 dangerJS |
iphone/Classes/TiErrorController.m
Outdated
| @@ -30,6 +42,7 @@ - (void)dealloc | |||
| RELEASE_TO_NIL(messageLabel); | |||
| RELEASE_TO_NIL(disclosureLabel); | |||
| RELEASE_TO_NIL(error); | |||
| RELEASE_TO_NIL(reason); | |||
There was a problem hiding this comment.
error and reason objects are autoreleased objects. These are released again here. It'll cause crash.
hansemannn
changed the title
|
Already handled via #10022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25747
no testsbecause it's a UI related change.