Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_1_X][TIMOB-17210] Android: Fixed TextField/TextArea to not trigger "change" event when setting properties #9834

Merged
merged 4 commits into from
Feb 26, 2018

Conversation

jquick-axway
Copy link
Contributor

…e" event when setting "value" and "attributedString" properties

- This is a back-port of Maggie Chen's fix on master.
@jquick-axway jquick-axway added this to the 7.1.0 milestone Feb 15, 2018
@jquick-axway jquick-axway changed the title [7_1_X][TIMOB-17210] Android: Fixed TextField/TextArea to not trigger "change" even when setting properties [7_1_X][TIMOB-17210] Android: Fixed TextField/TextArea to not trigger "change" event when setting properties Feb 15, 2018
@build build added the android label Feb 15, 2018
@longton95 longton95 self-requested a review February 16, 2018 18:34
@build build added the android label Feb 16, 2018
@build
Copy link
Contributor

build commented Feb 19, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR passed.

Tested using the test case the ticket and above, the event is only triggered when the text is changed by the user and not programmatically set.

It is now the same as iOS

ENV

SDK Version : 7.0.2.GA, Local 7.1.0
macOS Sierra 10.13.3
Google Pixel 2 XL (8.1.0)
android emulator (7.1.1)
Appc CLI : 7.0.2
Appc NPM : 4.2.12
Node : v8.9.1

@longton95 longton95 merged commit 26d4216 into tidev:7_1_X Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants