Skip to content

Commit

Permalink
fix(build): fix windows build of Titanium SDK - titanium_mobile (#13431)
Browse files Browse the repository at this point in the history
* fix: package.json broken build:local missing node command on last instruction

* fix: packager.js used an unknown -y command for zip

* fix: remove zip -y flag only for windows
  • Loading branch information
DzzD committed May 17, 2022
1 parent 122fa59 commit 6566453
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion build/lib/packager.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ const TITANIUM_PREP_LOCATIONS = [
*/
async function zip(cwd, filename) {
const command = os.platform() === 'win32' ? path.join(ROOT_DIR, 'build/win32/zip') : 'zip';
await exec(`${command} -9 -q -r -y "${path.join('..', path.basename(filename))}" *`, { cwd });
const params = os.platform() === 'win32' ? '-9 -q -r' : '-9 -q -r -y';
await exec(`${command} ${params} "${path.join('..', path.basename(filename))}" *`, { cwd });

const outputFolder = path.resolve(cwd, '..');
const outputFile = path.join(outputFolder, path.basename(filename));
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"android": "node ./build/scons cleanbuild android",
"build": "node ./build/scons build",
"build:local": "node ./build/scons build && node ./build/scons package --skip-zip && ./build/scons install",
"build:local": "node ./build/scons build && node ./build/scons package --skip-zip && node ./build/scons install",
"build:android": "npm run build -- android",
"build:changelog": "conventional-changelog -n changelog/config.js -i CHANGELOG.md -s -p angular",
"build:docs": "docgen apidoc -o ./dist",
Expand Down

0 comments on commit 6566453

Please sign in to comment.