Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes alignment on opaque types as discueed with @tidwall #13

Merged
merged 1 commit into from
May 12, 2024

Conversation

deckarep
Copy link
Contributor

@deckarep deckarep commented May 11, 2024

Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.

Please ensure you adhere to every item in this list

  • This PR was pre-approved by the project maintainer
  • I have self-reviewed the code
  • I have added all necessary tests

Describe your changes

Please provide detailed description of the changes.

When using this library from Zig, the Zig compiler caught some undefined behavior with respect to the opaque types. The fix as discussed with @tidwall was to override the default alignment on the exported opaque types and added the necessary static_assert checks to the internal types such that they match.

#11

@tidwall tidwall merged commit 3d4da9f into tidwall:main May 12, 2024
1 check passed
@tidwall
Copy link
Owner

tidwall commented May 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants