Fix leaking http connections #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. This looks much cleaner. Thanks. |
|
It works on my side. Big thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced problems with leaking http connections. We receive hooks by http, all connections are keep-alived. After few hours of our testing we noticed that we`ve got ~400 opened connections despite of hardcoded limit to 20. Also we had same number of goroutines both on server & client sides.
Default http client runs standalone goroutine for every connection so code in
Expireddoesn`t close these connections it just set client tonil. And new created client opens and runs new goroutines for new connection.