Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for tidy.ridgelm returning inconsistent columns (#532) #533

Merged

Conversation

jmuhlenkamp
Copy link
Contributor

@jmuhlenkamp jmuhlenkamp commented Nov 20, 2018

No description provided.

@jmuhlenkamp
Copy link
Contributor Author

jmuhlenkamp commented Nov 20, 2018

This is a proposed fix for #532

@alexpghayes
Copy link
Collaborator

alexpghayes commented Nov 22, 2018

Looks fantastic! Thank you for the fix and for digging into this even though I haven't been around much to respond to your comments!

@alexpghayes alexpghayes merged commit 8fa2bf4 into tidymodels:master Nov 22, 2018
@jmuhlenkamp jmuhlenkamp deleted the tidy.ridgelm-strict-tests branch Nov 24, 2018
@github-actions
Copy link

github-actions bot commented Mar 10, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants