Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move some packages to suggests #22

Closed
topepo opened this issue Mar 2, 2021 · 2 comments
Closed

move some packages to suggests #22

topepo opened this issue Mar 2, 2021 · 2 comments

Comments

@topepo
Copy link
Member

topepo commented Mar 2, 2021

If we don't use code that is pkg::func here, we should move the dependency to Suggests and use rlang::check_installed() when it is called (which I think happens automatically in parsnip).
@hfrick hfrick mentioned this issue Apr 16, 2021
Closed
@hfrick
Copy link
Member

hfrick commented Apr 16, 2021

keeping the more general #39 and closing this one

@hfrick hfrick closed this as completed Apr 16, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topepo @hfrick