Diagonal matrix #55
Diagonal matrix #55
Conversation
DESCRIPTION
Outdated
| @@ -1,6 +1,6 @@ | |||
| Package: corrr | |||
| Type: Package | |||
| Version: 0.2.1.9000 | |||
| Version: 0.3.0.9999 | |||
There was a problem hiding this comment.
Please change this back to 0.2.1.9000. I tend to work as follows:
- Start with dev version (ending .9000) and remain on it until a CRAN release
- For CRAN release change to next version (e.g.,
0.3.0) - Once on CRAN, flag release on GitHub and change to dev version on next change (by appending
.9000)
I tend to follow advice here.
Which reminded me, the next version should actually be 1.0.0 (due to backward compatible issue). Regardless, we'll wait until ready for a CRAN release.
NEWS.md
Outdated
|
|
||
| # corrr 0.1.0 | ||
|
|
||
| # corrr 0.3.0.9999 |
There was a problem hiding this comment.
Will also need to change this back
|
Aside, I've also just merged another pull request that may create some conflicts. Please pull origin and check against these. |
|
Ok, merged changes and switched versioning to previous version. |
|
Thanks for fixing and another nice addition to corrr! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
I fixed
as_matrixand setdiagonalas optional (also in docs), added tests to check that it inherits the correct diagonal and replaced all of theas_matrixcalls within other functions toas_matrix(diagonal = 1)to avoid breaking code. From my sidecheck()is successful. Let me know if this is ok, or do you need other changes.