Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new parameters for tidymodels/embed#213 #324

Merged
merged 6 commits into from Feb 22, 2024
Merged

new parameters for tidymodels/embed#213 #324

merged 6 commits into from Feb 22, 2024

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 21, 2024

For UMAP steps.

EmilHvitfeldt
EmilHvitfeldt approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 1 request

R/param_initial_umap.R Outdated Show resolved Hide resolved
R/param_target_weight.R Show resolved Hide resolved
hfrick and others added 4 commits February 22, 2024 09:15
@hfrick @EmilHvitfeldt
Update R/param_initial_umap.R
25699c4 
Co-authored-by: Emil Hvitfeldt <emilhhvitfeldt@gmail.com>
@hfrick
add details
e0db1be
@hfrick
document()
e72f828
@hfrick
update NEWS
65dca5b
@hfrick
Copy link
Member

hfrick commented Feb 22, 2024

Thanks both! 🙌

@hfrick hfrick merged commit fca8a58 into main Feb 22, 2024
10 of 11 checks passed
@hfrick hfrick deleted the new-embed-param branch February 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfrick hfrick hfrick approved these changes

@EmilHvitfeldt EmilHvitfeldt EmilHvitfeldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@topepo @hfrick @EmilHvitfeldt