Merge pull request #67 from tidymodels/cli-check_args

test {cli} changes to `check_args()`

tests/testthat/_snaps/flexible.md

@@ -0,0 +1,30 @@
+# check_args() works
+
+    Code
+      spec <- discrim_flexible(prod_degree = 0) %>% set_engine("earth") %>% set_mode(
+        "classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `prod_degree` must be a whole number larger than or equal to 1 or `NULL`, not the number 0.
+
+---
+
+    Code
+      spec <- discrim_flexible(num_terms = 0) %>% set_engine("earth") %>% set_mode(
+        "classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `num_terms` must be a whole number larger than or equal to 1 or `NULL`, not the number 0.
+
+---
+
+    Code
+      spec <- discrim_flexible(prune_method = 2) %>% set_engine("earth") %>% set_mode(
+        "classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `prune_method` must be a single string or `NULL`, not the number 2.
+

tests/testthat/_snaps/linear.md

@@ -0,0 +1,10 @@
+# check_args() works
+
+    Code
+      spec <- discrim_linear(penalty = -1) %>% set_engine("MASS") %>% set_mode(
+        "classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `penalty` must be a number larger than or equal to 0 or `NULL`, not the number -1.
+

tests/testthat/_snaps/regularized.md

@@ -0,0 +1,20 @@
+# check_args() works
+
+    Code
+      spec <- discrim_regularized(frac_common_cov = -1) %>% set_engine("klaR") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `frac_common_cov` must be a number between 0 and 1 or `NULL`, not the number -1.
+
+---
+
+    Code
+      spec <- discrim_regularized(frac_identity = -1) %>% set_engine("klaR") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    Condition
+      Error in `fit()`:
+      ! `frac_identity` must be a number between 0 and 1 or `NULL`, not the number -1.
+

tests/testthat/test-flexible.R

@@ -128,3 +128,37 @@ test_that("updating", {
   fda_spec_3 <- update(fda_spec, num_terms = 6)
   expect_equal(fda_spec_2, fda_spec_3)
 })
+
+test_that('check_args() works', {
+  skip_if_not_installed("earth")
+  skip_if_not_installed("parsnip", "1.2.1.9001")
+
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_flexible(prod_degree = 0) %>% 
+        set_engine("earth") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_flexible(num_terms = 0) %>% 
+        set_engine("earth") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_flexible(prune_method = 2) %>% 
+        set_engine("earth") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+})

tests/testthat/test-linear.R

@@ -0,0 +1,13 @@
+test_that('check_args() works', {
+  skip_if_not_installed("parsnip", "1.2.1.9001")
+
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_linear(penalty = -1) %>% 
+        set_engine("MASS") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+})

tests/testthat/test-naive-Bayes.R

@@ -201,3 +201,9 @@ test_that("updating", {
     ignore_formula_env = TRUE
   )
 })
+
+test_that("check_args() works", {
+  skip_if_not_installed("parsnip", "1.2.1.9001")
+  # Here for completeness, no checking is done
+  expect_true(TRUE)
+})

tests/testthat/test-quad.R

@@ -0,0 +1,4 @@
+test_that("check_args() works", {
+  # Here for completeness, no checking is done
+  expect_true(TRUE)
+})

tests/testthat/test-regularized.R

@@ -0,0 +1,23 @@
+test_that('check_args() works', {
+  skip_if_not_installed("parsnip", "1.2.1.9001")
+
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_regularized(frac_common_cov = -1) %>% 
+        set_engine("klaR") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+
+  expect_snapshot(
+    error = TRUE,
+    {
+      spec <- discrim_regularized(frac_identity = -1) %>% 
+        set_engine("klaR") %>%
+        set_mode("classification")
+      fit(spec, factor ~ ., glass_tr)
+    }
+  )
+})