Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fastNaiveBayes as engine to naive_bayes() #5

Closed
EmilHvitfeldt opened this issue Feb 25, 2020 · 6 comments · Fixed by #6
Closed

Adding fastNaiveBayes as engine to naive_bayes() #5

EmilHvitfeldt opened this issue Feb 25, 2020 · 6 comments · Fixed by #6
Labels
feature a feature request or enhancement

Comments

@EmilHvitfeldt
Copy link
Member

Would you be open for a PR adding https://github.com/mskogholt/fastNaiveBayes as an engine to naive_bayes()?
@EmilHvitfeldt EmilHvitfeldt changed the title fastNaiveBayes Adding fastNaiveBayes as engine to naive_bayes() Feb 25, 2020
@topepo
Copy link
Member

topepo commented Feb 27, 2020

I'm not a fan of this. It is only fast because it pushes the work on the user. I think that we would end up fielding issues in our repos because it deliberately operates differently than most packages.

@EmilHvitfeldt
Copy link
Member Author

Alright, sounds reasonable.

@EmilHvitfeldt
Copy link
Member Author

EmilHvitfeldt commented Feb 27, 2020 •
edited
Loading

what about naive_bayes() from the naivebayes package? That one was available in caret.

https://github.com/majkamichal/naivebayes

@EmilHvitfeldt EmilHvitfeldt reopened this Feb 27, 2020
@topepo
Copy link
Member

topepo commented Apr 3, 2020

That looks fine. Should I or do you want to take a shot at it?

@topepo topepo added the feature a feature request or enhancement label Apr 3, 2020
@EmilHvitfeldt
Copy link
Member Author

I can take a shot at it

@EmilHvitfeldt EmilHvitfeldt mentioned this issue Apr 3, 2020
Merged
@topepo topepo closed this as completed in #6 Apr 6, 2020
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add naivebayes engine to naive_Bayes
2 participants
@topepo @EmilHvitfeldt