Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move uwot to Suggests? #226

Open
hfrick opened this issue Aug 5, 2024 · 1 comment
Open

Move uwot to Suggests? #226

hfrick opened this issue Aug 5, 2024 · 1 comment
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hfrick
Copy link
Member

hfrick commented Aug 5, 2024 •
edited
Loading

Follow-up to https://github.com/tidymodels/embed/pull/225/files#r1703885441

uwot fails to install in the GHA for current oldrel-4. We should look into if we can enable that again by

  • moving uwot to Suggests
  • skipping installation of that package conditional on R version in the GHA yaml
  • safeguarding the corresponding tests with skip_if_installed()

This is based on tidymodels/censored#322
@hfrick hfrick mentioned this issue Aug 5, 2024
Merged
@EmilHvitfeldt
Copy link
Member

I'm game

@EmilHvitfeldt EmilHvitfeldt added the upkeep maintenance, infrastructure, and similar label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hfrick @EmilHvitfeldt