Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mold.data.frame() should be documented with default_xy_engine() #62

Closed
DavisVaughan opened this issue Feb 26, 2019 · 2 comments · Fixed by #64
Closed

mold.data.frame() should be documented with default_xy_engine() #62

DavisVaughan opened this issue Feb 26, 2019 · 2 comments · Fixed by #64

Comments

@DavisVaughan
Copy link
Member

DavisVaughan commented Feb 26, 2019

Do the same with the other engines

mold() is more of a stub that pushes you through to the other engine specific mold() pages.

That is where documentation for x and y is done, which makes the documentation cleaner to read.

@DavisVaughan
Copy link
Member Author

This means that new_default_xy_engine and the other new_default_*() constructors should be moved to their own page (they share lots of arguments anyways, and if we left them in there with mold.data.frame it would just be confusing)

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant