Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop argument to rep_slice_sample() #361

Closed
ismayc opened this issue Feb 4, 2021 · 2 comments · Fixed by #364
Closed

Add prop argument to rep_slice_sample() #361

ismayc opened this issue Feb 4, 2021 · 2 comments · Fixed by #364

Comments

@ismayc
Copy link
Collaborator

ismayc commented Feb 4, 2021

It's useful when bootstrapping to specify a prop argument instead of the number of rows if keeping things basic and not getting into the {infer} pipeline. This was requested on the {moderndive} package here, but since we import rep_sample_n() from {infer} we probably should import rep_slice_sample() as well. We'd prefer to not have two different versions of the same function floating around (one with prop and one without).

@simonpcouch
Copy link
Collaborator

All for it!🦥 Will put in a PR here in a bit.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants