Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication #177

Merged
merged 12 commits into from Aug 14, 2018
Merged

Reduce code duplication #177

merged 12 commits into from Aug 14, 2018

Commits on Aug 12, 2018

  1. Use is_nuat(x, at) wrapper for is.null(attr(x, at)).

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    1083bb3 View commit details
    Browse the repository at this point in the history

  2. Refactor set_attributes() into more flexible copy_attrs().

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    e641688 View commit details
    Browse the repository at this point in the history

  3. Refactor calc_impl() methods.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    d18be57 View commit details
    Browse the repository at this point in the history

  4. Move common data in tests into separate helper file.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    a88f028 View commit details
    Browse the repository at this point in the history

  5. DRY visualization of theoretical distributions.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    f684df4 View commit details
    Browse the repository at this point in the history

  6. DRY visualization of "both" distributions.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    738bd0c View commit details
    Browse the repository at this point in the history

  7. DRY warning in visualization about right-tailed tests.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    80f016b View commit details
    Browse the repository at this point in the history

  8. DRY visualization of p-value shades. 

    This also implements fixed shade transparency for all types of plots. Earlier it was fixed for "theoretical" and varied for "simulation" and "both".
    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    2cc4fe7 View commit details
    Browse the repository at this point in the history

  9. DRY and standardize theory type names. 

    Also this renames "Chi-square" into "Chi-Square" in warnings about right-tailed tests.
    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    f592b7f View commit details
    Browse the repository at this point in the history

  10. Fix style in 'test-visualize.R'.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    421e91f View commit details
    Browse the repository at this point in the history

  11. Update 'NEWS.md'.

    @echasnovski
    echasnovski committed Aug 12, 2018
    Copy the full SHA
    a675cf5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Account for prior adding of visualise(). 

    Merge branch 'develop' into dry-code

# Conflicts:
#	R/visualize.R
    @echasnovski
    echasnovski committed Aug 14, 2018
    Copy the full SHA
    cee866f View commit details
    Browse the repository at this point in the history