Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match outputs with broom tidiers? #20

Closed
alexpghayes opened this issue Feb 27, 2019 · 4 comments
Closed

Match outputs with broom tidiers? #20

alexpghayes opened this issue Feb 27, 2019 · 4 comments

Comments

@alexpghayes
Copy link

Just was taking a look at the kmeans tidier!

Would it make sense to match outputs up with the broom tidiers to the degree possible for consistency within tidyverse / db universe? Or to provide augment(), glance() and tidy() methods for database models?

@edgararuiz-zz
Copy link
Collaborator

Yeah, that's a great idea. Is there a spec I should look at?

@alexpghayes
Copy link
Author

For an easy start I'd just copy what tidy.lm() and tidy.kmeans(), etc, do. I'm working on exporting tests for modeltests but it's messy at the moment. Hopefully will get cleaned up sometime over the summer, but progress is slow. There's also the vignette on adding new tidiers to broom.

@edgararuiz-zz
Copy link
Collaborator

edgararuiz-zz commented Jul 11, 2019

Fixed by tidymodels/tidypredict@67bd599

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants