Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tests for empty selection tidy methods #1133

Closed
EmilHvitfeldt opened this issue Apr 26, 2023 · 1 comment · Fixed by #1143
Closed

Fix incorrect tests for empty selection tidy methods #1133

EmilHvitfeldt opened this issue Apr 26, 2023 · 1 comment · Fixed by #1143
Labels
upkeep maintenance, infrastructure, and similar

Comments

@EmilHvitfeldt
Copy link
Member

EmilHvitfeldt commented Apr 26, 2023 •
edited

empty selection tidy method works

The following steps don't return 0-row tibbles

  • poly_bernstein
  • spline_b
  • spline_convex
  • spline_monotone
  • spline_natural
  • spline_nonnegative
  • profile

Originally posted by @EmilHvitfeldt in #1131 (comment)
@EmilHvitfeldt EmilHvitfeldt added the upkeep maintenance, infrastructure, and similar label Apr 26, 2023
@EmilHvitfeldt EmilHvitfeldt mentioned this issue May 11, 2023
Merged
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure all steps return zero row tibble with empty selection tidymodels/recipes
1 participant
@EmilHvitfeldt