add infrastructure section to all step test files

[EmilHvitfeldt]

This PR is part of #1130.

This PR seems like it is doing a lot, but it is just moving tests around. Looking at it commit by commit is very helpful.

I'm defining infrastructure tests as tests that should be used on all steps, or all applicable tests. All steps should test that they print correctly, and all steps that uses check_name() should test that they are used. These are infrastructure tests.

Tests under the infrastructure section should be in alphabetical order, for no other reason than to avoid confusion when new tests are added

• Each step_*() and check_*() file gets an # Infrastructure ---------- section in their test file.
• renamed test-factors2string.R to match name of step
• split mutate() and rename() tests into 2 each to the _at() variants have their own files.

Moved over tests that should be called for each step

[EmilHvitfeldt]

Missing test

Empty printing

c(
"tests/testthat/test-geodist.R",                                                    
"tests/testthat/test-interact.R",
"tests/testthat/test-intercept.R",
"tests/testthat/test-mutate.R", # one test called "no input"
"tests/testthat/test-nnmf_sparse.R",
"tests/testthat/test-sample.R",
"tests/testthat/test-select.R"
)

printing

c(
"tests/testthat/test-newvalues.R",
"tests/testthat/test-nnmf_sparse.R"                              
)

empty selection tidy method works

c("
tests/testthat/test-geodist.R", 
"tests/testthat/test-interact.R",                                  
"tests/testthat/test-intercept.R", 
"tests/testthat/test-lag.R", 
"tests/testthat/test-mutate.R", 
"tests/testthat/test-nnmf_sparse.R", 
"tests/testthat/test-sample.R", 
"tests/testthat/test-select.R"
)

empty selection prep/bake is a no-op

c("tests/testthat/test-arrange.R", 
"tests/testthat/test-classdist.R",                                 
"tests/testthat/test-count.R", 
"tests/testthat/test-depth.R", 
"tests/testthat/test-geodist.R",
 "tests/testthat/test-interact.R", 
"tests/testthat/test-intercept.R", 
"tests/testthat/test-mutate.R", 
"tests/testthat/test-nnmf_sparse.R",
"tests/testthat/test-regex.R", 
"tests/testthat/test-sample.R", 
"tests/testthat/test-select.R"
)

bake method errors when needed non-standard role columns are missing

Some of these might be false negatives. E.i. I need to think about if all steps needs this test

c(
"tests/testthat/test-arrange.R",
 "tests/testthat/test-class.R",                                     
"tests/testthat/test-colcheck.R", 
"tests/testthat/test-corr.R", 
"tests/testthat/test-dummy_multi_choice.R", 
"tests/testthat/test-filter.R", 
"tests/testthat/test-filter_missing.R", 
"tests/testthat/test-intercept.R", 
"tests/testthat/test-lincomb.R", 
"tests/testthat/test-missing.R", 
"tests/testthat/test-mutate.R", 
"tests/testthat/test-mutate_at.R", 
"tests/testthat/test-naomit.R", 
"tests/testthat/test-newvalues.R", 
"tests/testthat/test-nnmf_sparse.R", 
"tests/testthat/test-nzv.R", 
"tests/testthat/test-poly_bernstein.R", 
"tests/testthat/test-profile.R", 
"tests/testthat/test-range_check.R", 
"tests/testthat/test-rename.R", 
"tests/testthat/test-rename_at.R", 
"tests/testthat/test-rm.R", 
"tests/testthat/test-sample.R", 
"tests/testthat/test-slice.R", 
"tests/testthat/test-spline_b.R", 
"tests/testthat/test-spline_convex.R", 
"tests/testthat/test-spline_monotone.R",
 "tests/testthat/test-spline_natural.R", 
"tests/testthat/test-spline_nonnegative.R",
 "tests/testthat/test-string2factor.R", 
"tests/testthat/test-time.R", 
"tests/testthat/test-window.R", 
"tests/testthat/test-zv.R"
)

[EmilHvitfeldt]

Incorrect tests

empty selection tidy method works

The following steps don't return 0-row tibbles

• poly_bernstein
• spline_b
• spline_convex
• spline_monotone
• spline_natural
• spline_nonnegative
• profile

[simonpcouch]

Thumbs up from me! Opened up one issue while reviewing that can be handled separately. Reviewing commit-by-commit was definitely helpful, thanks. :) Didn't dig very deeply into most of these changes—trusting that these indeed just move things around.

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.