Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step_lag should have an order_by argument #171

Open
alexpghayes opened this issue Jul 16, 2018 · 1 comment
Open

step_lag should have an order_by argument #171

alexpghayes opened this issue Jul 16, 2018 · 1 comment
Labels
feature a feature request or enhancement

Comments

@alexpghayes
Copy link
Contributor

Currently it requires that the input tibble is appropriately sorted, but we could just pass a column to sort by to dplyr::lag in the implementation. Probably can get around to this at some point, but it's a low priority atm.

@juliasilge juliasilge added the feature a feature request or enhancement label Aug 28, 2020
@EmilHvitfeldt
Copy link
Member

I'm working on a package that handles timed data in recipes. So I think this type of feature would be better served as step_time_lag() that will be added to that package.

I will keep this issue open while I wait for the package to materialize and visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants