Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type for itemprop is not specified #34

Closed
robertandrews opened this issue Mar 18, 2022 · 1 comment
Closed

Type for itemprop is not specified #34

robertandrews opened this issue Mar 18, 2022 · 1 comment

Comments

@robertandrews
Copy link

In a couple of areas, W3C HTML Validator reports:

The itemprop attribute was specified, but the element is not a property of any item.

  • Multiple when echoing the site name and description
  • Post titles

This StackOverflow answer says:

You should explicitly provide a type these properties (name, description, image) belong to.

In Schema.org, everything is a Thing. Thing has many child types, listed under "More specific Types". Start there and choose the most specific type for your content.

For example: WebPage, Article or maybe BlogPosting.

It could look like (using WebPage as example here):

Were you leaving the type blank for end users, given the range of options?

@bhadaway
Copy link
Owner

Thank you for all the feedback!

Fixed. (correct me if I'm wrong)

Of all the issues you raised:

  1. span wrapping p issue — This was just an oversight.
  2. datetime format issue — This is something I went back and forth on, and decided to remove, but just didn't think validation was necessary.
  3. schema issue — This one has been a constant pain point when it comes to the review process on wordpress.org. One admin/reviewer tells be it's allowed and another tells me it isn't. It seems to be a gray area on whether it's "plugin territory" or not. I make a case for it being theme territory, and entirely appropriate to bake schema right into the theme code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants