Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs #14

Closed
10 tasks done
mblue9 opened this issue Jul 20, 2022 · 3 comments
Closed
10 tasks done

TODOs #14

mblue9 opened this issue Jul 20, 2022 · 3 comments

Comments

@mblue9
Copy link
Member

mblue9 commented Jul 20, 2022

Keeping track of what we still need to do

@mblue9
Copy link
Member Author

mblue9 commented Jul 26, 2022

For investigate why base R code block different to tidy the difference is because the base R code was using the raw counts assay while tidy join_features uses the logcounts assay.

I've changed the base R code to use logcounts here (if that's not right let me know).

Noticed that there doesn't seem to be a way to use the raw counts with tidySCE join_features here, or to specify which assay to use if multiple present, so opened issue in tidySCE to note that. It's not something that has to be fixed before workshop I think.

@stemangiola
Copy link
Member

Noticed that there doesn't seem to be a way to use the raw counts with tidySCE join_features here, or to specify which assay to use if multiple present, so opened issue in tidySCE to note that. It's not something that has to be fixed before workshop I think.

join_features should have an assay argument assay="counts"

@mblue9
Copy link
Member Author

mblue9 commented Jul 26, 2022

Ah perfect that works 👍 I'll close the other issue.

@mblue9 mblue9 closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants