Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits from workshop discussion meeting #10

Merged
merged 21 commits into from
Jul 20, 2022
Merged

Edits from workshop discussion meeting #10

merged 21 commits into from
Jul 20, 2022

Conversation

mblue9
Copy link
Member

@mblue9 mblue9 commented Jul 14, 2022

No description provided.

@mblue9
Copy link
Member Author

mblue9 commented Jul 18, 2022

Testing out the merged PR now, should I add tidysc as package here?

   Error: processing vignette 'tidytranscriptomics_case_study.Rmd' failed with diagnostics:
   there is no package called 'tidysc'

@stemangiola
Copy link
Member

Testing out the merged PR now, should I add tidysc as package here?

   Error: processing vignette 'tidytranscriptomics_case_study.Rmd' failed with diagnostics:
   there is no package called 'tidysc'

I am incorporating the function now. I will push the changes very soon

@mblue9
Copy link
Member Author

mblue9 commented Jul 18, 2022

Ok great, one other thing I notice at the moment is that we still have some Seurat commands for the bit below in the vignette, are there Bioconductor equivalents we could use instead?

It is then possible to perform analyses on these gamma delta T cells by simply chaining further commands, such as below.


sce_obj_gamma_delta |>

  # Reanalyse
  NormalizeData(assay="RNA") |>
  FindVariableFeatures( nfeatures = 100, assay="RNA") |>
  SplitObject(split.by = "file") |>
  RunFastMNN(assay="RNA") |>
  RunUMAP(reduction = "mnn", dims = 1:20) |>
  FindNeighbors( dims = 1:20, reduction = "mnn") |>
  FindClusters( resolution = 0.3)

@stemangiola
Copy link
Member

I have the feeling we solved this problem with one of the BioC workshops. With BioC data reanalysis.

@mblue9
Copy link
Member Author

mblue9 commented Jul 18, 2022

@mblue9
Copy link
Member Author

mblue9 commented Jul 18, 2022

Besides above I think the main thing we need is a bit more explanation for the pseudobulk part on what's being done and the code as for prerequisites we only require basic tidyverse/single cell so some more text/comments e.g. on the steps and nest, map, map2, map_int would be good. If you could add a couple more comments I could flesh out text once the code runs (need above tidysc bit).

@mblue9 mblue9 merged commit d963998 into master Jul 20, 2022
@mblue9 mblue9 mentioned this pull request Jul 20, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants