TIMESTAMP is incorrect CAST type for MySQL & MariaDB #1189

Activity

1. avsdev-cw commented on Mar 13, 2023

   

   avsdev-cw

   on Mar 13, 2023

   ContributorAuthor

   More actions

   Further to this, the correct datetime format for mysql and mariadb differs from the default:

   sql_escape_datetime.DBIConnection <- function(con, x) {
     x <- strftime(x, "%Y-%m-%dT%H:%M:%OSZ", tz = "UTC")
     sql_escape_string(con, x)
   }

   The correct format according to the docs (https://dev.mysql.com/doc/refman/8.0/en/datetime.html) is:

   sql_escape_datetime.MariaDBConnection <- function(con, x) {
     x <- strftime(x, "%Y-%m-%d %H:%M:%OS", tz = "UTC")
     sql_escape_string(con, x)
   }
2. avsdev-cw commented on Mar 13, 2023

   

   avsdev-cw

   on Mar 13, 2023

   ContributorAuthor

   More actions

   Also related, (see the links in the first post), DOUBLE/FLOAT is the correct CAST type for numeric, not NUMERIC.
3. mgirlich commented on Mar 14, 2023

   

   mgirlich

   on Mar 14, 2023

   Collaborator

   More actions

   Do you want to create a PR for this? 😄
4. avsdev-cw commented on Mar 14, 2023

   

   avsdev-cw

   on Mar 14, 2023

   ContributorAuthor

   More actions

   Done 😄
5. mgirlich

   closed this as completedin #1195on Apr 25, 2023