Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbplyr 2.4.0- breaking changes #1416

Closed
kelseyroberts opened this issue Nov 29, 2023 · 2 comments · Fixed by #1396
Closed

dbplyr 2.4.0- breaking changes #1416

kelseyroberts opened this issue Nov 29, 2023 · 2 comments · Fixed by #1396
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@kelseyroberts
Copy link

With the updates to dbplyr version 2.4.0 it seems like some of the arguments that worked in the previous version, I was using version 2.3.2, no longer work.

The 3 main differences we are seeing is

  1. The "database" argument needs to be called “catalog” now
  2. "schemaname" needs to be called “schema”
  3. "tablename" needs to be called “table”

Database to catalog
For example this call used to work with the argument “database”:

database_connection_object%>%
  tbl(DBI::Id(
    database = "db1",
    schema = "schema1",
    table = "table1"
  )) %>%
  collect()

This now requires “database” to be named “catalog” as seen below:

database_connection_object%>%
  tbl(DBI::Id(
    catalog = "db1",
    schema = "schema1",
    table = "table1"
  )) %>%
  collect()

Schemaname and Tablename
“schemaname” and “tablename” were arguments that worked before and are now also giving errors:

database_connection_object%>%
  tbl(DBI::Id(
    database = "db1",
    schemaname = "schema1",
    tablename = "table1"
  )) %>%
  collect()

schemaname and tablename now are required to be “schema” and “table”:

database_connection_object%>%
  tbl(DBI::Id(
    database = "db1",
    schema= "schema1",
    table= "table1"
  )) %>%
  collect()
@hadley
Copy link
Member

hadley commented Dec 6, 2023

Yes, sorry about that. I'm working on a fix in #1396. I'm hoping I can finish it off next week and get it to CRAN soon after.

@hadley hadley added the bug an unexpected problem or unintended behavior label Dec 19, 2023
@hadley
Copy link
Member

hadley commented Dec 19, 2023

FWIW the goal is to get to a place where you can write:

con %>%
  tbl(I("db1.schema1.table1")) %>%
  collect()

Which is quite a bit less typing 😄

@hadley hadley mentioned this issue Dec 22, 2023
5 tasks
@hadley hadley added this to the 2.4.1 milestone Feb 14, 2024
@hadley hadley closed this as completed in ae1debb Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants