New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline `filter()` in `semi/anti_join()` #884

Closed

mgirlich opened this issue May 20, 2022 · 0 comments · Fixed by #1306

Labels

feature verb trans 🤖

Collaborator

mgirlich commented May 20, 2022

library(dplyr, warn.conflicts = FALSE)
library(dbplyr, warn.conflicts = FALSE)

lf <- lazy_frame(x = 1, y = 2, z = 3)
lf2 <- lazy_frame(x = 1, a = 2, b = 3)

semi_join(
  lf,
  lf2 %>% 
    filter(a == 1),
  by = "x"
)

Currently produces

SELECT *
FROM `df` AS `LHS`
WHERE EXISTS (
  SELECT 1 FROM (
    SELECT *
    FROM `df`
    WHERE (`a` = 1.0)
  ) `RHS`
  WHERE (`LHS`.`x` = `RHS`.`x`)
)

But could be

SELECT *
FROM `df` AS `LHS`
WHERE EXISTS (
  SELECT 1 FROM
  FROM `df` AS `RHS`
  WHERE (`RHS`.`a` = 1.0) AND (`LHS`.`x` = `RHS`.`x`)
)

hadley added feature verb trans 🤖 labels

mgirlich mentioned this issue

Inline filter() on y in semi/anti_join() #1306

Merged

mgirlich closed this as completed in #1306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment