Add step_relocate #162
Merged
Add step_relocate #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 17, 2020
tests/testthat/test-step-subset.R
Outdated
| @@ -38,6 +38,11 @@ test_that("simple calls generate expected translations", { | |||
| expr(DT[, .(a = x, y)]) | |||
| ) | |||
|
|
|||
| expect_equal( | |||
There was a problem hiding this comment.
I think relocate() is complicated enough that it should have it's own test case — it needs to have an example of exactly one of .before and .after, neither of them, and both of them. I'd also look at https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-relocate.R to see if there are other tricky cases we should also test for here.
There was a problem hiding this comment.
I've added tests based off dplyr, as suggested. I also added one to ensure relocation does not change the grouping variables.
Require 1.0.0 to allow new features of dplyr to be mirrored in dtplyr
Conflicts: DESCRIPTION R/step-subset.R
And match test file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines code from
step_select()anddplyr::relocate()to createstep_relocate(). I added one basic test, unsure if more are needed. Also thought that maybe@import dplyr relocateneeds to happen conditioned on dplyr version, but not quite sure how to handle that.Edit: The failing tests are due to a change in tibble 3.0: glimpse() uses "Rows" and "Columns" instead of "Variables" and "Observations", because we're not sure if the data is tidy here (#614).