Change as_factor() to convert ordered factors to plain factors
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test for as_factor stripping order add news item as_factor ordered change fix as_factor
hadley
reviewed
Jan 31, 2020
|
Thanks @robinsones! |
|
Unfortunately I had to revert this PR because it causes haven to fail R CMD check. That's totally a bug with haven, but because haven has C warnings that are slightly outside of my control, it's unfortunately easier to revert here than to squeeze out a quick haven release. |
hadley
added a commit
that referenced
this pull request
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216.
I used
structure()as that's whatas_factor.characteruses. Added two tests and a NEWS item as well.