Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with strip_dots and anonymous functions #1154

Closed
NikNakk opened this issue Jul 3, 2015 · 3 comments
Closed

Problem with strip_dots and anonymous functions #1154

NikNakk opened this issue Jul 3, 2015 · 3 comments

Comments

@NikNakk
Copy link
Contributor

@NikNakk NikNakk commented Jul 3, 2015

The current code which handles anonymous functions within strip_dots (in aes_calculated.r) is broken for anonymous functions. With pairlists, it tries to lapply each member of the pairlist to itself lapply(expr, expr) which I think will always result in an error.

Minimal reproducible example:

ggplot2:::strip_dots(quote(function(x) x))

I'm about to submit a pull request which fixes this issue.

@jeremycg
Copy link

@jeremycg jeremycg commented Jul 3, 2015

Nice one! see also the original q on stackoverflow: http://stackoverflow.com/questions/31212054/functions-inside-aes/

@NikNakk
Copy link
Contributor Author

@NikNakk NikNakk commented Jul 3, 2015

I was the one to answer that question (Nick K on SO)! I've mentioned it in the pull request but forgot to put it into the issue.

@hadley
Copy link
Member

@hadley hadley commented Jul 23, 2015

Fixed in #1155

@hadley hadley closed this Jul 23, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants