Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent argument order and formatting for layer functions #1305

Closed
hadley opened this issue Aug 29, 2015 · 2 comments
Closed

Consistent argument order and formatting for layer functions #1305

hadley opened this issue Aug 29, 2015 · 2 comments
Labels
feature a feature request or enhancement
Milestone
v2.1.0

Comments

@hadley
Copy link
Member

hadley commented Aug 29, 2015

No description provided.

@hadley
Copy link
Member Author

hadley commented Oct 13, 2015

Should be:

  • data, mapping, geom, stat, position
  • ...
  • parameters
  • common layer params (inherit.aes etc)

@hadley hadley closed this as completed in 4668ce7 Oct 13, 2015
@hadley hadley reopened this Oct 13, 2015
@hadley
Copy link
Member Author

hadley commented Oct 13, 2015

Grr, wrong issue.

@hadley hadley mentioned this issue Jan 26, 2016
Closed
@hadley hadley added the feature a feature request or enhancement label Jan 26, 2016
@hadley hadley added this to the v2.1.0 milestone Jan 26, 2016
@hadley hadley closed this as completed in 067e096 Jan 26, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
1 participant
@hadley