New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot2::waiver throws a warning on r-devel #1968

Closed
bgoodri opened this Issue Dec 27, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@bgoodri

bgoodri commented Dec 27, 2016

The recent R commit r71841 deprecates what ggplot2::waiver does. In the development version of R,

ggplot2::waiver()

yields

Warning message:
In structure(NULL, class = "waiver") :
Calling 'structure(NULL, *)' is deprecated, as NULL cannot have attributes.
Consider 'structure(list(), *)' instead.

This is leading to some largely spurious test failures in other packages that use testthat::expect_silent() but end up calling something in ggplot2 that calls waiver internally.

@bbolker

This comment has been minimized.

Contributor

bbolker commented Dec 29, 2016

just to follow up:

  • occurs here
  • being discussed on r-pkg-devel here

@hadley hadley closed this in bd7d9d6 Dec 30, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.