Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warning when using fixed coordinates with free scales? #2049

Closed
cpsievert opened this issue Feb 20, 2017 · 1 comment
Closed

Throw warning when using fixed coordinates with free scales? #2049

cpsievert opened this issue Feb 20, 2017 · 1 comment

Comments

@cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Feb 20, 2017

The coord_fixed() bit in the example below is silently ignored.

library(ggplot2)
ggplot(mtcars) + 
  geom_point(aes(wt, mpg)) + 
  facet_wrap(~vs, scales = "free") + 
  coord_fixed()

I'm not sure whether ggplot2 should allow for fixed coordinates in conjunction with free scales, but assuming the answer is "no", maybe we should add a message/warning/error?

@hadley
Copy link
Member

@hadley hadley commented Feb 26, 2017

Want to have a go at a PR? I think free scales probably should default to a warning, except for coords where it words (IIRC only coord_cartesian() and coord_flip())

@hadley hadley closed this in b0eea4b Nov 1, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants