Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_sas: "b7dat" and "b7cat" are inaccurate parameter names #214

Closed
evanmiller opened this issue Aug 24, 2016 · 1 comment
Closed

read_sas: "b7dat" and "b7cat" are inaccurate parameter names #214

evanmiller opened this issue Aug 24, 2016 · 1 comment

Comments

@evanmiller
Copy link
Collaborator

The file format names are sas7bdat ("SAS 7 Binary Data") and sas7bcat ("SAS 7 Binary Catalog"). Moving the 7 after the b does not make much sense. I would suggest renaming to one of:

  • sas7bdat/sas7bcat
  • bdat/bcat
  • data/catalog
  • data_file/catalog_file
@hadley hadley closed this as completed in 884980a Aug 24, 2016
@hadley
Copy link
Member

hadley commented Aug 24, 2016

Ooops! Thanks for spotting this

@lock lock bot locked and limited conversation to collaborators Jun 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @evanmiller