Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.name_repair does not accept a function in read_ #684

Closed
olivroy opened this issue Jun 10, 2022 · 1 comment · Fixed by #686
Closed

.name_repair does not accept a function in read_ #684

olivroy opened this issue Jun 10, 2022 · 1 comment · Fixed by #686
Labels
bug an unexpected problem or unintended behavior

Comments

@olivroy
Copy link

olivroy commented Jun 10, 2022

It only works with the string

I tested with .dta and .sav and I get the same error message.

read_dta("file.dta", .name_repair = make.names)
#> Error expected string vector of length 1.

In the doc., it says that it accepts rlang functions.

Edit : due to @inheritParams tibble::as_tibble, but from PR #478, we see that this argument is only for passing the string argument.

@gorcha gorcha added the bug an unexpected problem or unintended behavior label Jun 15, 2022
@gorcha
Copy link
Member

gorcha commented Jun 23, 2022

Hi! Thanks for the report.

Similarly to #685, the documentation definitely doesn't align with the behaviour of the argument. As with that issue my preference would be to update the behaviour to match as_tibble(), but I'll have to see how much work is involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants