Fix condition expectations in prevision of testthat breaking change #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
|
We're planning on releasing to CRAN soon, so I'd really appreciate it if you could do a release so we avoid breaking a CRAN check for your package 😄 |
|
Releasing today. |
|
Thanks! |
|
hms 1.1.1 on CRAN now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning a breaking change to the condition expectations in testthat release (see NEWS item in r-lib/testthat#1401). This PR implements a preventive fix that works with and without the breaking change.
There is no hurry to get this fix on CRAN since we are skipping one released version of testthat before going through with the change.