Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multidplyr throws warning when used with dplyr 0.7.0 #57

Closed
hokerl opened this issue Jun 16, 2017 · 3 comments
Closed

multidplyr throws warning when used with dplyr 0.7.0 #57

hokerl opened this issue Jun 16, 2017 · 3 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@hokerl
Copy link

hokerl commented Jun 16, 2017

Using multidplyr with dplyr 0.7.0 generates the following warning:
group_indices_.grouped_df ignores extra arguments

Minimal example:
mtcars %>% partition(cyl) %>% collect()

It seems to have no impact on the calculated results, but I am not sure if that's always the case...

@MGousseff
Copy link

MGousseff commented Oct 16, 2017

I encounter this problem as well. Thought it did no harm, but I do get problems in a more complex function...
Could it be linked to the weird if condition in the group_indices.grouped_df function :
if(length(list(...))
?

Please don't burn me if this is just something I didn't understand, as I am so grateful that these tools exist.

@Ilia-Kosenkov
Copy link

Ilia-Kosenkov commented Nov 15, 2018

I found the source of the warning. It happens in the call group_id <- dplyr::group_indices_(data), line 47 in shard.R, which in turn throws in group_indices.grouped_df, line 62 in dplyr/group-indices.R. Here is a reprex:

dplyr::group_indices_(dplyr::group_by_(mtcars, "gear"))
#> Warning: group_indices_.grouped_df ignores extra arguments
#>  [1] 2 2 2 1 1 1 1 2 2 2 2 1 1 1 1 1 1 2 2 2 1 1 1 1 1 2 3 3 3 3 3 2

Created on 2018-11-15 by the reprex package (v0.2.1.9000)

Unfortunately, no idea how to fix it.

@hadley hadley added the bug an unexpected problem or unintended behavior label Jul 11, 2019
@hadley
Copy link
Member

hadley commented Jul 12, 2019

This appears to be fixed by latest updates.

@hadley hadley closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants