Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for parse_number() behavior with non-numeric characters #1424

Closed
sbearrows opened this issue Aug 25, 2022 · 0 comments · Fixed by #1432
Closed

Clarify docs for parse_number() behavior with non-numeric characters #1424

sbearrows opened this issue Aug 25, 2022 · 0 comments · Fixed by #1432

Comments

@sbearrows
Copy link
Contributor

Developed from #1415

We might want to clarify the docs for how parse_number() handles special characters found after the first valid number. Right now the docs for parse_number() says:

This drops any non-numeric characters before or after the first number.

I think this is a bit confusing since there could be valid numbers after the first number, for example:

readr::parse_number("132aa000")
#> [1] 132

Created on 2022-08-25 by the reprex package (v2.0.1.9000)
Maybe something like:

"This parses the first number it finds, dropping any non-numeric characters before the first number and all characters after the first number."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant