Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't read non-lowercase .XLSX or .xlsm files #19

Closed
apjanke opened this issue Mar 19, 2015 · 3 comments · Fixed by #20
Closed

Won't read non-lowercase .XLSX or .xlsm files #19

apjanke opened this issue Mar 19, 2015 · 3 comments · Fixed by #20

Comments

@apjanke
Copy link
Contributor

apjanke commented Mar 19, 2015

Looks like the code for identifying the file type is being case-sensitive with extensions, so it will open .xlsx files but not .XLSX.

> read_excel("epoch-1900.XLSX")
Error: Don't know how to parse extension XLSX

Since the extension-based file type detection on platforms Excel runs on is typically case-insensitive, it seems like read_excel should be too, with respect to detecting file formats.

It won't read .xlsm files, either. They're the same format as .xlsx, just with macros enabled.

> read_excel("with-macro.xlsm")
Error: Don't know how to parse extension xlsm
@hadley
Copy link
Member

hadley commented Mar 20, 2015

Want to try a pull request? It's a fairly simple fix

@apjanke
Copy link
Contributor Author

apjanke commented Mar 20, 2015

Sure! Give me a little time, though; I'm an R newbie.

@apjanke
Copy link
Contributor Author

apjanke commented Mar 20, 2015

All right, made a pull request for this, #20.

@lock lock bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants