bring error msg in line with allowed matrix/df cols as per #416

[maxheld83]

Since matrix/df columns are now allowed, maybe this error msg should be changed accordingly, as well as respective tests.

Didn't mention df's explicitly, because those are, after all, lists.

[jennybc]

I've been staring at this message too, in my study of the name repair stuff.

If you look at the tests that exercise this, the "bogus" columns are NULL, an environment, and a quoted expression. Maybe it's safest to say 'something of this class is not allowed' and no longer attempt to give such a short description of what is allowed in the error message itself?

tibble/tests/testthat/test-data-frame.R

Lines 21 to 35 in 997f5e2

	expect_error(
	tibble(a = NULL),
	error_column_must_be_vector("a", "NULL"),
	fixed = TRUE
	)
	expect_error(
	tibble(a = new.env()),
	error_column_must_be_vector("a", "environment"),
	fixed = TRUE
	)
	expect_error(
	tibble(a = quote(a)),
	error_column_must_be_vector("a", "name"),
	fixed = TRUE
	)

[maxheld83]

Great idea, that makes this short and sweet. (Well or sour, actually, since it’s an error message).

Do you think I should take another try at this?

[krlmlr]

Thanks. Would "1d or 2d objects" be a sufficiently short and clear description? The error message needs to mention data frames anyway, they are treated differently from list columns.

We should agree on the wording before doing further implementation work.

[maxheld83]

I like the 1d/2d distinction a lot because (if you get it) it explains why which objects work and which don’t (they need to be vectors of equal length or nrows).
But I’m wondering how widespread this terminology is in R, especially to novices.
Guess not everyone will immediately know that a matrix is a 2d object/vector.

[jennybc]

Would "1d or 2d objects" be a sufficiently short and clear description?

Sounds good to me.

[codecov]

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          26       26           
  Lines        1080     1080           
=======================================
  Hits          981      981           
  Misses         99       99

Impacted Files	Coverage Δ
R/msg.R	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997f5e2...fc613ce. Read the comment docs.

[maxheld83]

done!

[krlmlr]

Thanks!