Should tibble::tibble() use quos(..., .named = TRUE)?

[DavisVaughan]

Is automatically adding names to unnamed ... too surprising? Was this first error expected?

# surprising?
tibble::tibble(!!! list(mtcars[,1:2], mtcars[,3:4]))
#> Column name `<data.frame>` must not be duplicated.
#> Use .name_repair to specify repair.

# a result of:
rlang::quos(!!! list(mtcars[,1:2], mtcars[,3:4]), .named = TRUE)
#> <list_of<quosure>>
#> 
#> $`<data.frame>`
#> <quosure>
#> expr: ^<data.frame>
#> env:  empty
#> 
#> $`<data.frame>`
#> <quosure>
#> expr: ^<data.frame>
#> env:  empty

# can be "fixed" with
tibble::tibble(!!! list(x = mtcars[,1:2], y = mtcars[,3:4]))
#> # A tibble: 32 x 2
#>    x$mpg  $cyl y$disp   $hp
#>    <dbl> <dbl>  <dbl> <dbl>
#>  1  21       6   160    110
#>  2  21       6   160    110
#>  3  22.8     4   108     93
#>  4  21.4     6   258    110
#>  5  18.7     8   360    175
#>  6  18.1     6   225    105
#>  7  14.3     8   360    245
#>  8  24.4     4   147.    62
#>  9  22.8     4   141.    95
#> 10  19.2     6   168.   123
#> # … with 22 more rows

tibble::tibble(!!! list(mtcars[,1:2], mtcars[,3:4]), .name_repair = "minimal")
#> # A tibble: 32 x 2
#>    `<data.frame>`$mpg  $cyl `<data.frame>`$disp   $hp
#>                 <dbl> <dbl>               <dbl> <dbl>
#>  1               21       6                160    110
#>  2               21       6                160    110
#>  3               22.8     4                108     93
#>  4               21.4     6                258    110
#>  5               18.7     8                360    175
#>  6               18.1     6                225    105
#>  7               14.3     8                360    245
#>  8               24.4     4                147.    62
#>  9               22.8     4                141.    95
#> 10               19.2     6                168.   123
#> # … with 22 more rows

^{Created on 2019-06-24 by the reprex package (v0.2.1)}

[krlmlr]

Related: #581 (which is about auto-splicing).

[krlmlr]

Maybe we should append ...# suffixes to auto-named columns here?

@lionel-: Should this be the default, or perhaps an option?

[lionel-]

The plan was originally to have name repair in rlang but it is now in vctrs instead. Can you use .named = FALSE and name the inputs manually?

[krlmlr]

Ideally I'd like to maintain full-width expressions, but width and printer in exprs_auto_name() are deprecated. Are there better alternatives?

[lionel-]

You can auto-name yourself in this case. I don't think full-width expressions are ideal though.

[krlmlr]

I don't think I want to auto-name myself, because we're striving for consistency with mutate() and summarize(). The auto-naming should live somewhere central -- I don't mind implementing it, but then dplyr might want to follow the same strategy. Or we do whatever rlang does, or perhaps tweak rlang?

[lionel-]

dplyr just uses .named = TRUE.

[krlmlr]

With current tibble:

tibble::tibble(!!! list(mtcars[,1:2], mtcars[,3:4]))
#> # A tibble: 32 x 4
#>      mpg   cyl  disp    hp
#>    <dbl> <dbl> <dbl> <dbl>
#>  1  21       6  160    110
#>  2  21       6  160    110
#>  3  22.8     4  108     93
#>  4  21.4     6  258    110
#>  5  18.7     8  360    175
#>  6  18.1     6  225    105
#>  7  14.3     8  360    245
#>  8  24.4     4  147.    62
#>  9  22.8     4  141.    95
#> 10  19.2     6  168.   123
#> # … with 22 more rows

^{Created on 2019-10-25 by the reprex package (v0.3.0)}

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.