Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Immediately breaks bench. I faintly remember we mentioned bench using expressions where it didn't have to?
#>  '184.108.40.20606'
bench::mark(x = 1)
#> All columns in a tibble must be 1d or 2d objects:
#> * Column `expression` is bench_expr
#> 36. └─bench::mark(x = 1)
#> 37. ├─base::summary(...) /Users/davis/Desktop/r/packages/bench/R/mark.R:120:2
#> 38. ├─bench:::bench_mark(tibble::as_tibble(results, validate = FALSE)) /Users/davis/Desktop/r/packages/bench/R/mark.R:120:2
#> 39. │ └─base::unique(c("bench_mark", class(x))) /Users/davis/Desktop/r/packages/bench/R/mark.R:124:2
#> 40. ├─tibble::as_tibble(results, validate = FALSE) /Users/davis/Desktop/r/packages/bench/R/mark.R:120:2
#> 41. └─tibble:::as_tibble.list(results, validate = FALSE)
#> 42. └─tibble:::lst_to_tibble(x, .rows, .name_repair, col_lengths(x))
#> 43. └─tibble:::check_valid_cols(x)
Created on 2019-09-30 by the reprex package (v0.2.1)
The text was updated successfully, but these errors were encountered:
I took a stab at tweaking vctrs so that this eventually becomes a non-issue.
Sorry, something went wrong.
It's not that simple to fix in vctrs.
Options, in order of my preference:
I think the second option wouldn't be too much of an effort to implement. We still can strive for the first option.
Option 2 would also be a breaking change, but if it doesn't break bench it'd be a reasonable workaround until we figure this out in vctrs.
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.
Successfully merging a pull request may close this issue.