Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace_na() will replace any empty input #1168

Closed
DavisVaughan opened this issue Oct 18, 2021 · 0 comments · Fixed by #1219
Closed

replace_na() will replace any empty input #1168

DavisVaughan opened this issue Oct 18, 2021 · 0 comments · Fixed by #1219
Labels
bug an unexpected problem or unintended behavior missing values 💀

Comments

@DavisVaughan
Copy link
Member

DavisVaughan commented Oct 18, 2021

tidyr::replace_na(list(character()), replace = "foo")
#> [[1]]
#> [1] "foo"

Created on 2021-10-18 by the reprex package (v2.0.1)

Due to is_complete()'s implementation. It should just replace NULLs


Not sure why replace_na() is using is_complete()? Should not be using "incompleteness" as a replacement condition, should probably just be using "missingness" (i.e. through vec_equal_na())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior missing values 💀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant