Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vroom::problems() work more like readr::problems() #443

Closed
jennybc opened this issue May 27, 2022 · 1 comment
Closed

Make vroom::problems() work more like readr::problems() #443

jennybc opened this issue May 27, 2022 · 1 comment

Comments

@jennybc
Copy link
Member

jennybc commented May 27, 2022

Seems like vroom::problems() could also consult .Last.value in the case of a missing primary input, as readr::problems() does.

https://github.com/tidyverse/readr/blob/5ac729aa9a70fef297a634d2332ff8ff1af874fb/R/problems.R#L24-L45

Seems like there should be more assessment of whether the input was explicitly provided or not. I think you'd want a higher level of skepticism / strictness for implicit input .Last.value than for explicitly passed input.

There will be several matters to think through here, around the co-existence and relationship between readr::problems() and vroom::problems().

@sbearrows
Copy link
Contributor

sbearrows commented Aug 17, 2022

This was meant to be closed with #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants