Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-vendor and re-patch grisu files #485

Open
jennybc opened this issue Jan 23, 2023 · 0 comments
Open

Re-vendor and re-patch grisu files #485

jennybc opened this issue Jan 23, 2023 · 0 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jennybc
Copy link
Member

jennybc commented Jan 23, 2023

I'd like to start this over from the beginning and record our changes as patch files that we apply. Motivation is 50/50 really wanting to have such a structured provenance (so it's totally clear what modifications we've made to the code), but also wanting to start codifying this sort of repetitive task (like what we do for data-raw/, but for vendored code r-lib/usethis#1698).

I think starting over would begin with source files from here, e.g.:

https://github.com/juj/MathGeoLib/blob/master/src/Math/grisu3.c

(which now contains a patch from us, deleting a rogue nonprinting character).

Helpful commands / process: https://www.thegeekstuff.com/2014/12/patch-command-examples/

@hadley hadley added the upkeep maintenance, infrastructure, and similar label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants