Align argument types and format strings

[jennybc]

Closes #523

[jennybc]

I can't say that I completely understand why the need for this was surfaced by the changes in the content and usage of r_utils.h. But I'm also not sure that I really need to get to the bottom of it.

[jennybc]

Inspired by https://github.com/wch/r-source/blob/75cd3117e23f2010634200875f2ef50a83461b8f/src/include/Rinternals.h#L71C1-L80

Who/what is going to define LONG_VECTOR_SUPPORT 🤔 ?

[jennybc]

I suppose it comes via cpp11/R.hpp, which includes Rinternals.h.

[gaborcsardi]

Yeah, it is coming from the R headers, you are allowed to use it.

[gaborcsardi]

This looks pretty good to me, much better than casting. But just to make sure, would you mind adding these to the CI matrix, temporarily?

• windows 4.2
• windows R-devel

Windows 4.2, because it uses yet another compiler that we do not test for currently, and R-devel because that's where the recent changes are.

I am still not entirely sure if it is going to work without a warning on older Linux, e.g. Centos/RedHat 7, I'll check it soon.

EDIT: seems fine on CentOS 7 as well (with gcc 4.8.5!), with R-release and R-devel.

[jennybc]

Checking on Windows with r-devel was revealing. The existing fixes all hold up, but I get some new hits in a totally different file, so I'm happy to learn about this now! I also sent everything to win-builder (devel, release, oldrel) and get completely consistent results: the new warnings seen below on devel, clean pass on release and oldrel.

Found the following significant warnings:
  unicode_fopen.h:52:52: warning: conversion lacks type at end of format [-Wformat=]
  unicode_fopen.h:52:14: warning: too many arguments for format [-Wformat-extra-args]
  unicode_fopen.h:78:52: warning: conversion lacks type at end of format [-Wformat=]
  unicode_fopen.h:78:14: warning: too many arguments for format [-Wformat-extra-args]

Update: I now see these additional warnings also in the CRAN results for windows + r-devel. I think that hadn’t shown up yet when I first got the email (or else I just overlooked it / assumed all flavours were complaining about the same things).