ACF/PACF/CCF conflict with dlookr package

[mitchelloharawild]

library(feasts)
#> Warning: package 'feasts' was built under R version 3.6.3
#> Loading required package: fabletools
library(dlookr)
#> Loading required package: mice
#> Warning: package 'mice' was built under R version 3.6.3
#> 
#> Attaching package: 'mice'
#> The following objects are masked from 'package:base':
#> 
#>     cbind, rbind
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo
#> Registered S3 method overwritten by 'inum':
#>   method          from   
#>   format.interval tsibble
#> 
#> Attaching package: 'dlookr'
#> The following object is masked from 'package:base':
#> 
#>     transform
tsibbledata::vic_elec %>% ACF(Temperature)
#> Error: <interval> + <integer> is not permitted

^{Created on 2020-06-14 by the reprex package (v0.3.0)}

[mitchelloharawild]

Caused by

feasts/R/acf.R

Line 229 in 21dc7a7

suffix <- substring(format(interval), first = nchar(format(scale)) + 1)

format(interval) is calling inum:::format.interval not tsibble:::format.interval

[mitchelloharawild]

Fixed.

library(feasts)
#> Loading required package: fabletools
library(dlookr)
#> Loading required package: mice
#> Warning: package 'mice' was built under R version 3.6.3
#> 
#> Attaching package: 'mice'
#> The following objects are masked from 'package:base':
#> 
#>     cbind, rbind
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo
#> Registered S3 method overwritten by 'inum':
#>   method          from   
#>   format.interval tsibble
#> 
#> Attaching package: 'dlookr'
#> The following object is masked from 'package:base':
#> 
#>     transform
tsibbledata::vic_elec %>% ACF(Temperature)
#> # A tsibble: 47 x 2 [30m]
#>      lag   acf
#>    <lag> <dbl>
#>  1   30m 0.994
#>  2   60m 0.982
#>  3   90m 0.967
#>  4  120m 0.948
#>  5  150m 0.925
#>  6  180m 0.901
#>  7  210m 0.873
#>  8  240m 0.845
#>  9  270m 0.815
#> 10  300m 0.785
#> # … with 37 more rows

^{Created on 2020-06-15 by the reprex package (v0.3.0)}

[Steviey]

(+1) #148