gg_season() for annual data #111

Activity

1. robjhyndman commented on Jul 27, 2020

   

   robjhyndman

   on Jul 27, 2020

   Member

   More actions

   I think it is simpler to interpret when starting at 1.
2. mitchelloharawild commented on Jul 27, 2020

   

   mitchelloharawild

   on Jul 27, 2020 via email

   Member

   More actions

   Yes, it should start at 1.

   …

   On Mon., 27 Jul. 2020, 15:25 Rob J Hyndman, ***@***.***> wrote: I think it is simpler to interpret when starting at 1. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#111 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD3BJFYG5HZG5JO6TA4UZTLR5UFTRANCNFSM4PILZCEA> .
3. mitchelloharawild

   closed this as completedin 9388b5eon Jul 28, 2020
4. mitchelloharawild commented on Jul 28, 2020

   

   mitchelloharawild

   on Jul 28, 2020

   Member

   More actions

   library(feasts)
   #> Loading required package: fabletools
   lynx_tsbl <- as_tsibble(lynx)
   gg_season(lynx_tsbl, value, period = "40 year")

   

   ^{Created on 2020-07-28 by the reprex package (v0.3.0)}
5. earowang commented on Jul 28, 2020

   

   earowang

   on Jul 28, 2020 via email

   MemberAuthor

   More actions

   The x-axis values are not expected, akin to other relevant issues. Cheers, Earo

   …

   On 29 Jul 2020, at 1:46, mitchelloharawild wrote: ``` r library(feasts) #> Loading required package: fabletools lynx_tsbl <- as_tsibble(lynx) gg_season(lynx_tsbl, value, period = "40 year") ```  ^{Created on 2020-07-28 by the [reprex package](https://reprex.tidyverse.org) (v0.3.0)} -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #111 (comment)
6. mitchelloharawild

   added a commit that references this issue on Jul 29, 2020

   Fix offset for numerics in gg_season

   ...

   37e50d0