Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gg_season() for annual data #111

Closed
earowang opened this issue Jul 27, 2020 · 4 comments
Closed

gg_season() for annual data #111

earowang opened this issue Jul 27, 2020 · 4 comments

Comments

@earowang
Copy link
Member

earowang commented Jul 27, 2020

Should the series of 1821 start at 0 instead of 21?

library(feasts)
#> Loading required package: fabletools
lynx_tsbl <- as_tsibble(lynx)
gg_season(lynx_tsbl, value, period = "40 year")

forecast::seasonplot(lynx, 40, type = "l")
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo

Created on 2020-07-27 by the reprex package (v0.3.0)

@robjhyndman
Copy link
Member

robjhyndman commented Jul 27, 2020

I think it is simpler to interpret when starting at 1.

@mitchelloharawild
Copy link
Member

mitchelloharawild commented Jul 27, 2020

@mitchelloharawild
Copy link
Member

mitchelloharawild commented Jul 28, 2020

library(feasts)
#> Loading required package: fabletools
lynx_tsbl <- as_tsibble(lynx)
gg_season(lynx_tsbl, value, period = "40 year")

Created on 2020-07-28 by the reprex package (v0.3.0)

@earowang
Copy link
Member Author

earowang commented Jul 28, 2020

mitchelloharawild added a commit that referenced this issue Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants