Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double submission of farmer record #32

Merged
merged 12 commits into from
Sep 19, 2019
Merged

Prevent double submission of farmer record #32

merged 12 commits into from
Sep 19, 2019

Conversation

Rexben001
Copy link
Contributor

@Rexben001 Rexben001 commented Sep 4, 2019 •
edited

Description

  • Check if a farmer record exists already
  • Returns an error message that farmer exists already

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works AND the tests pass

@Rexben001 Rexben001 marked this pull request as ready for review September 4, 2019 10:00
@Rexben001 Rexben001 force-pushed the prevent-double-submit branch 3 times, most recently from 20e107f to 61f79a5 Compare September 4, 2019 13:02
@Rexben001 Rexben001 requested a review from Pav0l September 4, 2019 13:42
Pav0l
Pav0l reviewed Sep 4, 2019
View reviewed changes
tests/farmers.test.js Outdated Show resolved Hide resolved
@Rexben001 Rexben001 force-pushed the prevent-double-submit branch 2 times, most recently from 6364411 to 434c044 Compare September 5, 2019 10:31
@Rexben001 Rexben001 requested a review from Pav0l September 5, 2019 10:53
@tiemendodeveloper tiemendodeveloper temporarily deployed to tndo-temp-staging September 5, 2019 14:48 Inactive
@Pav0l
Copy link
Collaborator

Pav0l commented Sep 5, 2019

Prevent double submits of farmer form

@tiemendodeveloper tiemendodeveloper temporarily deployed to tndo-temp-staging September 10, 2019 15:07 Inactive
Pav0l
Pav0l previously approved these changes Sep 17, 2019
View reviewed changes
Copy link
Collaborator

@Pav0l Pav0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the failing tests 👍

daquinons
daquinons previously approved these changes Sep 18, 2019
View reviewed changes
quansenB
quansenB previously approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@quansenB quansenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@tiemendodeveloper tiemendodeveloper temporarily deployed to tieme-ndo-backend-staging1 September 18, 2019 16:04 Inactive
@quansenB quansenB self-requested a review September 18, 2019 16:13
@quansenB quansenB dismissed stale reviews from daquinons, Pav0l, and themself via e11be95 September 18, 2019 16:22
@tiemendodeveloper tiemendodeveloper temporarily deployed to tieme-ndo-backend-staging1 September 18, 2019 16:23 Inactive
@tiemendodeveloper tiemendodeveloper temporarily deployed to tieme-ndo-backend-staging1 September 18, 2019 16:42 Inactive
@tiemendodeveloper tiemendodeveloper temporarily deployed to tieme-ndo-backend-staging1 September 18, 2019 16:44 Inactive
@tiemendodeveloper tiemendodeveloper temporarily deployed to tndo-temp-staging September 19, 2019 07:47 Inactive
quansenB
quansenB previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@quansenB quansenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and Review finsihed

@quansenB quansenB self-requested a review September 19, 2019 08:07
quansenB
quansenB approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@quansenB quansenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is reviewed and QA'ed

@Pav0l Pav0l merged commit 3590cd7 into master Sep 19, 2019
@Pav0l Pav0l deleted the prevent-double-submit branch September 19, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quansenB quansenB quansenB approved these changes

@daquinons daquinons daquinons left review comments

@Pav0l Pav0l Pav0l left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rexben001 @Pav0l @daquinons @quansenB @tiemendodeveloper